Closed Bug 1882300 Opened 1 year ago Closed 8 months ago

[DE][hessnatur.com] Form autofill/preview/clear aren't applied on all the eligible fields

Categories

(Toolkit :: Form Autofill, task, P3)

Firefox 125
Desktop
macOS
task

Tracking

()

VERIFIED FIXED
133 Branch
Tracking Status
firefox123 --- disabled
firefox124 --- disabled
firefox125 --- disabled
firefox133 --- verified
firefox134 --- verified

People

(Reporter: hyacoub, Assigned: enndeakin)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [fxcm-addr-compatibility] )

Attachments

(2 files)

Found in

  • Firefox Nightly 125.0a1

Affected versions

  • Firefox Nightly 125.0a1

Tested platforms

  • Affected platforms: macOS 11.6

Preconditions

  • Install DE Firefox build
  • Use DE VPN
  • browser.search.region = DE
  • extensions.formautofill.addresses.experiments.enabled - true
  • extensions.formautofill.addresses.supportedCountries = DE
  • extensions.formautofill.addresses.capture.requiredFields = empty

Steps to reproduce

  1. Reach the address form on https://www.hessnatur.com
  2. Click on "Name" field
  3. Select any of the options for the dropdown
  4. Right click on any of the fields and choose "Clear autofill form"
  5. Repeat steps from above for the rest of the fields

Expected result

  • Form autofill/preview/clear should be applied on eligible fields.

Actual result

  • Form autofill/preview/clear are only applied on the selected field.

Regression range

  • N/A

Additional notes

Blocks: 1882480
No longer blocks: 1882480
Priority: -- → P3

All the fields seem to filled in except for the street which is not being detected.

Whiteboard: [fxcm-addr-compatibility]

The issue here is that <label> elements are not connected to the input element -- they have no 'for' attribute, and the street's formfield name is just 'line1' so it does not matched.

The solution here is probably to guess that the a label without a 'for' attribute that otherwise doesn't match is meant to correspond to a neighboring input field. In this site here, the input immediately precedes the label.

Assignee: nobody → enndeakin
Status: NEW → ASSIGNED

This is a somewhat limited fix and only handles form controls that are adjacent to the label, and does not handle those that might be a nested styled element.

Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7cd8cf2eac0 if a label does not have a corresponding control, assume that a sibling is meant to be that control, r=credential-management-reviewers,dimi
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch

Verified as Fixed on MacOS 14, Windows 11 and Ubuntu 22.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: